Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] rma_sale #507

Closed
wants to merge 271 commits into from
Closed

[17.0][MIG] rma_sale #507

wants to merge 271 commits into from

Conversation

CarlosVForgeFlow
Copy link

DavidJForgeFlow and others added 22 commits March 25, 2024 12:50
- auto_confirm_rma_sale
- free_of_charge_rma_sale
OCA was added in the past by mistake only because a misconfiguration
in the CI forced OCA as a required author.
Otherwise the anglo saxon entries won't be correct.
For example, the Interim (Delivered) account should balance
after receiving and triggering a refund on a customer rma.
Without this, some policies are not being copied from the
operation selected when creating new rma line from a rma group.

In v16 this patch and the usage of such onchange can be removed
in favor of (pre)computed stored editable fields for all policies
and configuration in the RMA operation.
…ma lines created (#452)

* [14.0][IMP] added default operation on rma group, easy setup before rma lines created

* [IMP] added fields for default route created by wizard on rma group

* fix: get right price after create rma order line
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.64847% with 660 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (17.0@4c64b8e). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             17.0     #507   +/-   ##
=======================================
  Coverage        ?   79.64%           
=======================================
  Files           ?       55           
  Lines           ?     3243           
  Branches        ?      593           
=======================================
  Hits            ?     2583           
  Misses          ?      499           
  Partials        ?      161           
Files Coverage Δ
rma/__init__.py 100.00% <100.00%> (ø)
rma/models/__init__.py 100.00% <100.00%> (ø)
rma/models/procurement_group.py 100.00% <100.00%> (ø)
rma/models/product.py 100.00% <100.00%> (ø)
rma/models/product_category.py 100.00% <100.00%> (ø)
rma/models/res_company.py 100.00% <100.00%> (ø)
rma/models/res_config_settings.py 100.00% <100.00%> (ø)
rma/tests/__init__.py 100.00% <100.00%> (ø)
rma/tests/test_rma.py 100.00% <100.00%> (ø)
rma/wizards/__init__.py 100.00% <100.00%> (ø)
... and 45 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c64b8e...ddbc215. Read the comment docs.

@CarlosVForgeFlow CarlosVForgeFlow marked this pull request as ready for review March 25, 2024 14:10
@AaronHForgeFlow
Copy link
Contributor

Carlos, can you please include #509 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.