Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bevy 0.11 #23

Merged
merged 8 commits into from
Aug 9, 2023
Merged

Update to Bevy 0.11 #23

merged 8 commits into from
Aug 9, 2023

Conversation

PikminGuts92
Copy link
Contributor

@PikminGuts92 PikminGuts92 commented Jul 15, 2023

Draft until bevy_flycam is updated sburris0/bevy_flycam#34 sburris0/bevy_flycam#35

Changes

  • Migrate to bevy 0.11
  • Update README with updated syntax

@rlidwka
Copy link

rlidwka commented Jul 17, 2023

Draft until bevy_flycam is updated

bevy_flycam was updated yesterday, so is this PR all good?

@PikminGuts92
Copy link
Contributor Author

bevy_flycam was updated yesterday, so is this PR all good?

Change was merged in, yes. But crates.io release is not available yet. Otherwise, it's completely functional aside from example.

Copy link

@Hibyehello Hibyehello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a couple thoughts on cleaning up all the add_systems

src/render/mod.rs Outdated Show resolved Hide resolved
src/render/shadow.rs Outdated Show resolved Hide resolved
@PikminGuts92
Copy link
Contributor Author

I just have a couple thoughts on cleaning up all the add_systems

@Hibyehello Great suggestions, thanks! Those changes are now pushed up. I also went ahead and updated the README to use newer syntax too

@IceSentry
Copy link
Collaborator

@PikminGuts92 thanks for making this PR. I'll merge it as is and will replace flycam for a simple camera controller copied from bevy. I don't want this PR to be blocked just because of a third party library only used in the example

@IceSentry IceSentry marked this pull request as ready for review August 9, 2023 21:52
@IceSentry IceSentry merged commit 4a4426b into ForesightMiningSoftwareCorporation:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants