Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Duel.GetSZoneCount #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add Duel.GetSZoneCount #257

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2019

If no spell&trap zone, Brotherhood of the Fire Fist - Rooster can send field spell to grave.

@DailyShana
Copy link
Contributor

I hope you can only focus on szone count and do not change others

@ghost
Copy link
Author

ghost commented Dec 19, 2019

It is better to unify those functions.
If those functions unified, some cards (e.g. The Weather Painter Sun) can use new check function (e.g. Card.IsAbleToField).

@DailyShana
Copy link
Contributor

DailyShana commented Dec 19, 2019

I don't think there is any improvement for The Weather Painter Sun, its script is simple and clear, nearly word-to-word translation from text to script

@ghost
Copy link
Author

ghost commented Dec 19, 2019

some to field effects cannot check perfectly.
so, it is better to add Card.IsAbleToField.

@DailyShana
Copy link
Contributor

if some card is going to mzone, check the count of mzone
if some card is going to szone, check the count of szone
even if some card is going to mzone or szone, the condition is just mzone>0 or szone>0

@ghost
Copy link
Author

ghost commented Dec 19, 2019

field::get_zone_count check mzone or szone only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant