Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL3 Support #1478

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SDL3 Support #1478

wants to merge 2 commits into from
+445 −0

Conversation

andyvand
Copy link

Add SDL3 support

@andyvand
SDL3 Support
63f66ec 
Add SDL3 support
derselbst
derselbst reviewed Jan 26, 2025
View reviewed changes
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick. Thanks a lot! I've only got one comment below. Before merging it, I'll adapt the Window CI pipeline in the next days, to make it compile with SDL3 support.

src/drivers/fluid_sdl3.c
} fluid_sdl3_audio_driver_t;

AudioDeviceList AudioSDL3PlaybackDevices;
AudioDeviceList AudioSDL3RecordingDevices;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to have these two declared globally. They are potentially modified concurrently by GetNumAudioDevices when called from new_fluid_sdl3_audio_driver. I'd suggest to move them into the fluid_sdl3_audio_driver_t struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derselbst derselbst derselbst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyvand @derselbst