Add gas host call #303
Merged
Add gas host call #303
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pvm-debugger ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomusdrw
approved these changes
Jan 21, 2025
| @@ -165,6 +165,12 @@ const hostCall = async ({ | |||
| await jamHostCall.execute(getGasCounter(pvm), getRegisters(pvm), getMemory(pvm)); | |||
|
|
|||
| return { hostCallIdentifier, storage, status: CommandStatus.SUCCESS }; | |||
| } else if (hostCallIdentifier === HostCallIdentifiers.GAS) { | |||
There was a problem hiding this comment.
https://github.com/FluffyLabs/typeberry/blob/main/packages/pvm/host-calls/host-calls-manager.ts#L10
Take a look at this code it's doing exactly the thing that you are doing here with a series of if-elses and handles a missing host call by returning some info back to the PVM.
You might consider using this instead.
There was a problem hiding this comment.
Interesting, I'll take some pieces from this when working on the import/export host calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.