Add ecalli handling for other pvms #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pvm-debugger ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krystian50
force-pushed
the
host-calls-multi-pvms
branch
from
8614d41 to
130fe5e
Compare
tomusdrw
approved these changes
Jan 15, 2025
| } | ||
|
|
||
| storeFrom(address: MemoryIndex, bytes: Uint8Array) { | ||
| this.pvm.setMemory(address, bytes); |
There was a problem hiding this comment.
Suggested change
| this.pvm.setMemory(address, bytes); | |
| // TODO [ToDr] Either change the API to require handling multi-page writes or change this code to split the write into multiple pages. | |
| this.pvm.setMemory(address, bytes); |
| payload: { hostCallIdentifier: worker.exitArg as HostCallIdentifiers }, | ||
| }); | ||
| if ( | ||
| resp.payload.hostCallIdentifier === HostCallIdentifiers.WRITE && |
There was a problem hiding this comment.
These HostCallIndentifiers should rather come from host calls impls (new Write().index) to avoid duplicating this stuff in case it ever changes.
There was a problem hiding this comment.
From what I'm seeing it's only exported as
import { write } from "@typeberry/jam-host-calls";
new write.Write().index
which is fine, but it requires account param. Maybe you could add index as a static property?
Co-authored-by: Tomek Drwięga <[email protected]>
Co-authored-by: Tomek Drwięga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.