API api to add Topology patches in worker manager #436
Conversation
infherny
changed the title
infherny
force-pushed
the
olivier/api_to_add_topology_patches
branch
2 times, most recently
from
36b2357
to
947bef2
Compare
| @@ -18,6 +20,7 @@ class BaseObject: | |||
| metadata: ObjectMetadata | |||
| apiVersion: str | |||
| kind: str | |||
| spec: dict[str, t.Any] | |||
There was a problem hiding this comment.
I added spec here to be able to load the spec from the patches.
infherny
force-pushed
the
olivier/api_to_add_topology_patches
branch
2 times, most recently
from
2a302eb
to
5022cb6
Compare
infherny
force-pushed
the
olivier/api_to_add_topology_patches
branch
from
5022cb6
to
0240ded
Compare
|
Im using |
|
I think the PK should include the kind, wdyt. Since the name is not especially unique across kind |
infherny
force-pushed
the
olivier/api_to_add_topology_patches
branch
from
0240ded
to
aae70c8
Compare
I did this change |
| sa.JSON, server_default="{}", nullable=False | ||
| ) | ||
|
|
||
| def __init__(self, topology: BaseObject) -> None: |
There was a problem hiding this comment.
nit, I would recommend to use a classmethod instead (from_topology)
| bp = Blueprint("topologies", __name__, url_prefix="/api/topologies") | ||
|
|
||
|
|
||
| @bp.route("", methods=("PUT",)) |
There was a problem hiding this comment.
route -> patch? /api/topologies could be used one day to actually create components.
| from saturn_engine.utils.sqlalchemy import upsert | ||
|
|
||
|
|
||
| def add(*, session: AnySession, topology: BaseObject) -> TopologyPatch: |
There was a problem hiding this comment.
add -> patch ? topology -> patch ?
There was a problem hiding this comment.
Does the renaming make sens now?
infherny
force-pushed
the
olivier/api_to_add_topology_patches
branch
2 times, most recently
from
991482b
to
02bc0eb
Compare
infherny
force-pushed
the
olivier/api_to_add_topology_patches
branch
from
02bc0eb
to
2281f75
Compare
The goal is to be able to dynamically edit topologies