Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support transient identities and traits #68

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 7, 2024

Closes #63.

  • Add optional transient argument to getFeatureFlags
  • Add optional transient attribute to Trait struct
  • Remove redundant identifier query parameter from POST /api/v1/identities call
  • Remove unneeded flags JSON body key from POST /api/v1/identities call
  • Update copyright in example app

- Add optional `transient` argument to  `getFeatureFlags`
- Add optional `transient` attribute to `Trait` struct
- Remove redundant `identifier` query parameter from `POST /api/v1/identities` call
- Remove unneeded `flags` JSON body key from `POST /api/v1/identities` call
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment, but looks pretty good to me.

FlagsmithClient/Classes/Traits.swift Outdated Show resolved Hide resolved
@khvn26 khvn26 merged commit ba0fb2b into main Oct 8, 2024
4 checks passed
@khvn26 khvn26 deleted the feat/transient-identities-and-traits branch October 8, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support transient identities and traits
2 participants