Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove tracking domain & tracking boolean #58

Merged

Conversation

gazreese
Copy link
Contributor

@gazreese gazreese commented May 15, 2024

Description

Remove our domain and tracking reference from the privacy manifest to hopefully fix #57

I've tried to reproduce the customer issue with the test app but unfortunately I've not been able to. My research however suggests that this fix should cover us, and is in-line with the privacy manifests of most of our contemporaries.

Removing the domain should stop it from being blocked when the user declines tracking.

The definition of 'tracking' WRT Apple is in here - https://developer.apple.com/app-store/user-privacy-and-data-use/

With the relevant Apple documentation here - https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't purport to understand everything in this PR, but it looks sound to me. Approving the PR and let's get a release out.

@matthewelwell matthewelwell merged commit 1104787 into Flagsmith:main May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP load failed, 0/0 bytes (error code: -1009 [1:50])
2 participants