"StrictConcurrency=complete" and preparation for upcoming Swift 6 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enabled `StrictConcurrency=complete` mode in order to be prepared for upcoming Swift 6. Implemented `Sendable` support for Flagsmith client and friends. - Enabled `ExistentialAny` feature in order to be prepared for upcoming Swift 6. Code adjustments - adjusted tests for `StrictConcurrency=complete` mode .
dabeeeenster
merged commit b34ec0d
into
Flagsmith:3a4oT/strict-concurency
2 checks passed
7 tasks
gazreese
pushed a commit
to foresightmobile/flagsmith-ios-client
that referenced
this pull request
Apr 25, 2024
…agsmith#48) * - Bumped `swift-tools` to swift 5.9. - Enabled `StrictConcurrency=complete` mode in order to be prepared for upcoming Swift 6. Implemented `Sendable` support for Flagsmith client and friends. - Enabled `ExistentialAny` feature in order to be prepared for upcoming Swift 6. Code adjustments - adjusted tests for `StrictConcurrency=complete` mode . * adjusted macOS runner * cleanup
matthewelwell
pushed a commit
that referenced
this pull request
May 2, 2024
* "StrictConcurrency=complete" and preparation for upcoming Swift 6 (#48) * - Bumped `swift-tools` to swift 5.9. - Enabled `StrictConcurrency=complete` mode in order to be prepared for upcoming Swift 6. Implemented `Sendable` support for Flagsmith client and friends. - Enabled `ExistentialAny` feature in order to be prepared for upcoming Swift 6. Code adjustments - adjusted tests for `StrictConcurrency=complete` mode . * adjusted macOS runner * cleanup * Merge branch 'feature/strinct-concurrency-gareth-updattes' into 3a4oT/strict-concurency * Revert version back to 3.5.0 * Add qos: parameter to our DispatchQueues to avoid console errors starting the SDK * Also add qos to the test app * Update to the latest macOS and the latest macOS (12) currently for the runners to check everything is fine * Let's build on 13 and 14 as 12 is too old * Reformat the files I couldn't merge and fix up some force-unwraps in the tests * One last lint error --------- Co-authored-by: Petro Rovenskyy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-toolsto swift 5.9.Enabled
StrictConcurrency=completemode to prepare for the upcoming Swift 6. ImplementedSendablesupport for the Flagsmith client and friends. Used@unchecked SendableandDispatch serial queue to implement thread-safeaccess to class properties.ExistentialAnyfeature to be prepared for the upcomingSwift 6. Code adjustmentsStrictConcurrency=completemode.