fix: Avoid recursion during identity features validation #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
novakzaballa
and removed request for
a team
khvn26
force-pushed
the
fix/avoid-recursion
branch
from
ad181a7
to
6e39cb2
Compare
khvn26
force-pushed
the
fix/avoid-recursion
branch
from
6e39cb2
to
8a52109
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8a52109 |
matthewelwell
approved these changes
Jan 17, 2024
|
@matthewelwell Can't imagine writing those without heavily mocking the pydantic_collections internal which I'd like to avoid. Ideally we need to add identity data with varied number of overrides to the common |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance regression where the unique identity feature states validation function was being executed recursively due to slicing the
pydantic_collections.BaseCollectionduring its validation.The changes make sure that only the underlying list gets sliced.