Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (core): Despawn on summoner fix and warning #183

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

fix (core): Despawn on summoner fix and warning #183

wants to merge 8 commits into from

Conversation

acidmanifesto
Copy link
Contributor

Changes proposed

  • further fix scripting and warning corrections with ci.

Known issues and TODO list

  • [ ]
  • [ ]
  • Thank you for collaborating with the project.
  • For an efficient working methodology.
  • It is obvious to make long pull request, unless it is necessary.
  • A short pull request would be easy to test and approve.

seobryn
seobryn approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@seobryn seobryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acidmanifesto
Copy link
Contributor Author

LGTM

Not yet finish at the moment. I am tracking down a issue at the moment.

@acidmanifesto acidmanifesto marked this pull request as draft October 20, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seobryn seobryn seobryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acidmanifesto @seobryn