New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (core): Workflow warning fixes #174

Merged

seobryn merged 2 commits into FirelandsProject:master from acidmanifesto:workflow-wanring-fixes

Sep 14, 2023

Contributor

acidmanifesto commented Sep 14, 2023

Changes proposed

Fixes workflow warnings
Fixes Format specifies type 'unsigned int' but the argument has type 'uint64' (aka 'unsigned long')
Adds missing overridden virtual functiona
Fix misleading indentation; statement is not part of the previous 'if'
Fix unused variables.

Thank you for collaborating with the project.
For an efficient working methodology.
It is obvious to make long pull request, unless it is necessary.
A short pull request would be easy to test and approve.


          chore (core): Workflow warning fixes

ba6b861

acidmanifesto requested a review from seobryn

September 14, 2023 15:52

Meltie2013 suggested changes

View reviewed changes

src/server/game/Spells/Spell.cpp Outdated Show resolved Hide resolved


          Update Spell.cpp

964eb67

seobryn approved these changes

View reviewed changes

seobryn merged commit f602b5b into FirelandsProject:master

3 checks passed

acidmanifesto deleted the workflow-wanring-fixes branch

September 22, 2023 13:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet