fix (core): change order in HandleLootOpcode #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just can not understand why we have a check occuring after SendLoot. All checks should be before it in this case. Viewing gitblame, this was last touched back about 13 years ago and with no notes explaining the reasoning. Would love a further explaination in the reason why interrupt cast if statement is occurring after a send loot and not before.
Changes proposed
Issues addressed
SOURCE:
Tests performed
How to Test the Changes:
cast spells or while crafting does get interrupted when i decide to loot something
Known issues and TODO list