Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paladin Spells Fixes #123

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

seobryn
Copy link
Contributor

@seobryn seobryn commented Aug 8, 2023

Changes proposed

  • Fix Judgement of the Just spell
  • Fix Grand Cruzader proc
  • Fix Eye for an Eye damage calculation on target

Issues addressed

  • Closes

SOURCE:

  • N/A

Tests performed

  • Build Test
  • In game Test

How to Test the Changes:

  1. Download the new core
  2. Build it
  3. Run the worldserver
  4. Create a paladin
  5. test the spells

Known issues and TODO list

  • N/A

  • Thank you for collaborating with the project.
  • For an efficient working methodology.
  • It is obvious to make long pull request, unless it is necessary.
  • A short pull request would be easy to test and approve.

@seobryn seobryn self-assigned this Aug 8, 2023
@seobryn seobryn merged commit e3c6273 into master Aug 8, 2023
2 checks passed
@seobryn seobryn deleted the feature/judgements-of-the-just branch August 8, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant