Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Modular system #115

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Feat: Modular system #115

merged 2 commits into from
Aug 3, 2023

Conversation

seobryn
Copy link
Contributor

@seobryn seobryn commented Aug 2, 2023

Changes proposed

  • Add to the core a Mods module that allow the developers, develop custom content using a Standarized way to keep all the code organized

Issues addressed

  • N/A

SOURCE:

  • This module Was Inspired in Azeroth core Module System implementation

Tests performed

  • Build Test
  • In game Test with a module

How to Test the Changes:

  1. Download the new Core Code
  2. Create a custom module using the command inside the Mods folder
  3. Run Cmake
  4. Compile it
  5. Run the game and test your mod.

Known issues and TODO list

  • Currently is necessary to run all the database script manually, we need to Update the Database Updater to get all the SQL changes automatically.

  • Thank you for collaborating with the project.
  • For an efficient working methodology.
  • It is obvious to make long pull request, unless it is necessary.
  • A short pull request would be easy to test and approve.

@seobryn seobryn self-assigned this Aug 2, 2023
@seobryn seobryn changed the title WIP: Modulde system Feat: Modular system Aug 3, 2023
@seobryn seobryn merged commit 5a8c304 into master Aug 3, 2023
2 checks passed
@seobryn seobryn deleted the feature/module-system branch August 3, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant