Add property FbCommand.NamedParameters (#1161) #1164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
requested changes
Mar 12, 2024
| @@ -198,6 +198,16 @@ public int FetchSize | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Gets collection of parameters parsed from the query text by <see cref="NamedParametersParser"/> during command prepare. | |||
There was a problem hiding this comment.
No need to mention NamedParametersParser. It's an implementation detail.
| /// <summary> | ||
| /// Gets collection of parameters parsed from the query text by <see cref="NamedParametersParser"/> during command prepare. | ||
| /// </summary> | ||
| [Category("Data")] |
There was a problem hiding this comment.
Not needed for getter-only properties. In fact it should be maybe hidden for designers.
| /// Gets collection of parameters parsed from the query text by <see cref="NamedParametersParser"/> during command prepare. | ||
| /// </summary> | ||
| [Category("Data")] | ||
| [DefaultValue(new string[] { })] |
There was a problem hiding this comment.
Not needed for getter-only properties. In fact it should be maybe hidden for designers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Are the property attributes correct?
Does the test tests the property properly?
Please let me know if you see an issue.
Thank you
Best regards
Daniel Trubač