Added server and client proxies so that the mod doesn't crash on dedicated server #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mod has been installed on a dedicated server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just used your mod in a modpack I've put together on the Curse Voice client, and understand that this is a client only mod. However, when I put packs together, I always ensure that the pack will work both on a client and dedicated server. It's not possible to maintain server versions of packs on the Curse Voice Client, so I only get a single pack that has to work on both server and client.
I've forked your mod, and have added a sided proxy, such that if the mod is installed on a dedicated server, no initialisation is performed, and the mod isn't loaded, however on a client, the mod will be loaded as normal. I've not made any other changes, so functionality shouldn't have changed.
If you're happy with the changes I've made, I'd be delighted if you'd merge these changes into your code base, then when the mod is next updated, players that use my pack (and other packs that use your mod), will have a nice easy method of getting a dedicated server up and running without having to deal with exceptions that they probably won't understand.