-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2025 UI typography updates #1935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
notlee
commented
Jan 17, 2025
•
edited
Loading
edited
- Removes components without an equivalent in Figma i.e. those replaced by a single CSS class for a typography use-case token.
- Replaces removed typography tokens with their new use-case counterpart.
This has been replaced by the title usecases.
This has been replaced by type usecases. Also removes remaining Heading stories.
This is now applied by default through foundations
Instead use type usecases
Instead use type usecases
Reduce html required for links. Apply dropcap with new modifier.
Remove last of old CSS Custom Props
frshwtr
reviewed
Jan 20, 2025
|
||
```diff | ||
- <p class="o3-editorial-typography-body">An article by <a class="o3-editorial-typography-link" href="https://ft.com/">The Financial Times</a></p>. | ||
+ <p class="o3-typography-use-case-body-content-base">An article by <a href="https://ft.com/">The Financial Times</a></p>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diffception 🤯
frshwtr
reviewed
Jan 20, 2025
frshwtr
reviewed
Jan 20, 2025
frshwtr
reviewed
Jan 20, 2025
frshwtr
reviewed
Jan 20, 2025
frshwtr
reviewed
Jan 21, 2025
Co-authored-by: Ben Freshwater <[email protected]>
frshwtr
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.