feat: adds Bluesky buttons to o-share #1911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aendra-rininsland
requested review from
ft-dependency-auto-merger and
a team
as code owners
aendra-rininsland
force-pushed
the
o-share_bluesky
branch
from
9e034f4 to
21cb4ce
Compare
aendra-rininsland
force-pushed
the
o-share_bluesky
branch
from
21cb4ce to
b409093
Compare
|
N.b., I've noticed that handles don't link very well at this point; I've opened an issue here: |
frshwtr
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
N.b., I'm not sure this is ready yet, please let me know if there's more I need to do. Thanks!
This adds Bluesky sharing intent buttons. N.b., this only uses the web endpoint; there's a
bluesky://protocol endpoint that is probably preferable on mobile but I'm not sure how to reference it in an isomorphic context.See: https://docs.bsky.app/docs/advanced-guides/intent-links#compose-post
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md