Code

Add dotcom-ui-data-embed#808

Code

Closed

NickColley wants to merge 19 commits intomasterFinancial-Times/dotcom-page-kit:masterfrom dotcom-ui-client-embedFinancial-Times/dotcom-page-kit:dotcom-ui-client-embedCopy head branch name to clipboard

+273-54

Commits

Commits on May 11, 2020

• Add boilerplate for dotcom-ui-client-embed package

  

  Nick Colley

  authored and

  Nick Colley

  committed
  8b39a0b

  Copy full SHA for 8b39a0b

• Refactor flags to align with appContext logic

  Show description for 19e21c5
  

  Nick Colley

  committed
  19e21c5

  Copy full SHA for 19e21c5

• Add reusable ClientEmbed component

  

  Nick Colley

  committed
  5c4a1d0

  Copy full SHA for 5c4a1d0

• Refactor AppContextEmbed to use shared ClientEmbed

  Show description for b010952
  

  Nick Colley

  committed
  b010952

  Copy full SHA for b010952

• Refactor FlagsEmbed to use shared ClientEmbed

  Show description for a0b4240
  

  Nick Colley

  committed
  a0b4240

  Copy full SHA for a0b4240

• Add loadClientEmbed

  Show description for 834f67f
  

  Nick Colley

  committed
  834f67f

  Copy full SHA for 834f67f

• Refactor loadAppContext to use loadClientEmbed

  

  Nick Colley

  committed
  cc6192d

  Copy full SHA for cc6192d

• Refactor loadFlags to use loadClientEmbed

  

  Nick Colley

  committed
  2f26db7

  Copy full SHA for 2f26db7

• Add client embed as a dependency for app context

  

  Nick Colley

  committed
  fa4738e

  Copy full SHA for fa4738e

• Add client embed as a dependency for flags

  

  Nick Colley

  committed
  8958580

  Copy full SHA for 8958580

• Add custom context example to kitchen sink

  

  Nick Colley

  committed
  289081e

  Copy full SHA for 289081e

• Add ClientEmbedData class for safer data retrieval

  Show description for 18989fe
  

  Nick Colley

  committed
  18989fe

  Copy full SHA for 18989fe

• Add fleshed out init methods and expose methods

  

  Nick Colley

  committed
  b6ee9c0

  Copy full SHA for b6ee9c0

• Update kitchen sink example to demonstrate new exposed methods

  

  Nick Colley

  committed
  5243d11

  Copy full SHA for 5243d11

• Refactor client embed id into a shared constant

  

  Nick Colley

  committed
  3b9a944

  Copy full SHA for 3b9a944

• Add ClientEmbedClient class

  Show description for d4f740b
  

  Nick Colley

  committed
  d4f740b

  Copy full SHA for d4f740b

• Move ClientEmbed tests into components/ folder

  

  Nick Colley

  committed
  6f9fe16

  Copy full SHA for 6f9fe16

• Rename dotcom-ui-client-embed to dotcom-ui-data-embed

  

  Nick Colley

  committed
  aa8683c

  Copy full SHA for aa8683c

Commits on May 12, 2020

• Refactor away from class to mirror nTracking

  

  Nick Colley

  committed
  7907e42

  Copy full SHA for 7907e42