Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT Bundle Splitting Strategy Helper #210

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Conversation

ifeanyiisitor
Copy link
Contributor

  • Implement getFTBundleAssetUrls function that returns asset urls specific to the FT bundling splitting strategy
  • Use ft bundle splitting strategy in example express app (server side)

@ifeanyiisitor ifeanyiisitor changed the title Ft FT Bundle Splitting Strategy Helper Mar 15, 2019
@@ -0,0 +1,30 @@
import AssetLoader from '@financial-times/anvil-server-asset-loader'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being used for typings. See line 6

@i-like-robots
Copy link
Contributor

cc #169 and requires #195

@ifeanyiisitor ifeanyiisitor merged commit e7fc366 into master Mar 18, 2019
@ifeanyiisitor ifeanyiisitor deleted the ify/anvil-server-ft-preset branch March 18, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants