Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

105 refactor patternmarkers #111

Closed
wants to merge 7 commits into from
Closed

105 refactor patternmarkers #111

wants to merge 7 commits into from

Conversation

dimalvovs
Copy link
Contributor

@dimalvovs dimalvovs commented Jun 13, 2024 •
edited
Loading

  • add PatternScores back
  • modularize
  • add axis back
  • update docs
  • review vignette

@dimalvovs dimalvovs linked an issue Jun 13, 2024 that may be closed by this pull request
Refactor - patternMarkers() #105
Closed
7 tasks
ejfertig
ejfertig approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@ejfertig ejfertig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected bugs in pattern markers and factored to be more modular to allow for updates.

@ejfertig
Copy link
Collaborator

Approve

@ejfertig ejfertig closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejfertig ejfertig ejfertig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor - patternMarkers()
2 participants
@dimalvovs @ejfertig