Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New vector interpolations and mappings #798

Draft
wants to merge 182 commits into
base: master
Choose a base branch
from

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Sep 23, 2023

Implements Hcurl (Nedelec) and Hdiv (RaviartThomas and BrezziDouglasMarini) interpolations and the associated mappings.

To ensure that the infrastructure works well, I would aim to have the following here

  • Tests for H(div) and H(curl) on reference element
  • Continuity testing for mapped H(div) and H(curl)
  • Test homogeneous Dirichlet BC for all interpolations
  • Tutorial with H(div) elements: preview
  • Tutorial with H(curl) elements preview
  • Test reinit without gradients

Possible tutorials/validations

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Attention: Patch coverage is 0% with 509 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (951ec47) to head (2fe350d).

Files with missing lines Patch % Lines
src/FEValues/boundary_integrals.jl 0.00% 198 Missing ⚠️
src/interpolations.jl 0.00% 129 Missing ⚠️
src/FEValues/EdgeValues.jl 0.00% 78 Missing ⚠️
src/FEValues/FunctionValues.jl 0.00% 47 Missing ⚠️
src/Quadrature/quadrature.jl 0.00% 24 Missing ⚠️
src/FEValues/BoundaryValues.jl 0.00% 21 Missing ⚠️
src/Dofs/ConstraintHandler.jl 0.00% 10 Missing ⚠️
src/iterators.jl 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (951ec47) and HEAD (2fe350d). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (951ec47) HEAD (2fe350d)
6 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #798       +/-   ##
==========================================
- Coverage   93.57%   0.00%   -93.58%     
==========================================
  Files          39      42        +3     
  Lines        6073    6504      +431     
==========================================
- Hits         5683       0     -5683     
- Misses        390    6504     +6114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/src/devdocs/mapping.md Outdated Show resolved Hide resolved
Copy link
Member

@termi-official termi-official Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this feature (+ tests) in a separate PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will.
Sorry that didn't update much on the plan with this PR, but it will need to be split into several sub-PRs. However, it is easier to work with the full one, and it can also serve as a reference when reviewing the sub-PRs later.

@@ -49,3 +49,24 @@ dofs defined on a specific entity. Hence, not overloading of the dof functions w
element with zero dofs. Also, it should always be double checked that everything is consistent as
specified in the docstring of the corresponding function, as inconsistent implementations can
lead to bugs which are really difficult to track down.

## Vector interpolation properties
### Hdiv interpolations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Hdiv interpolations
### H(div) interpolations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to add some comments about the De-Rahm complex here for readers not familiar with the topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for H(curl) and H(div) elements
5 participants