-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: New vector interpolations and mappings #798
base: master
Are you sure you want to change the base?
Conversation
… error though (test fails)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 93.57% 0.00% -93.58%
==========================================
Files 39 42 +3
Lines 6073 6504 +431
==========================================
- Hits 5683 0 -5683
- Misses 390 6504 +6114 ☔ View full report in Codecov by Sentry. |
…-FEM/Ferrite.jl into kam/FunctionValuesGeneralization
src/FEValues/EdgeValues.jl
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this feature (+ tests) in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will.
Sorry that didn't update much on the plan with this PR, but it will need to be split into several sub-PRs. However, it is easier to work with the full one, and it can also serve as a reference when reviewing the sub-PRs later.
@@ -49,3 +49,24 @@ dofs defined on a specific entity. Hence, not overloading of the dof functions w | |||
element with zero dofs. Also, it should always be double checked that everything is consistent as | |||
specified in the docstring of the corresponding function, as inconsistent implementations can | |||
lead to bugs which are really difficult to track down. | |||
|
|||
## Vector interpolation properties | |||
### Hdiv interpolations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Hdiv interpolations | |
### H(div) interpolations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to add some comments about the De-Rahm complex here for readers not familiar with the topic.
Implements Hcurl (Nedelec) and Hdiv (RaviartThomas and BrezziDouglasMarini) interpolations and the associated mappings.
To ensure that the infrastructure works well, I would aim to have the following here
Possible tutorials/validations