Videoplayer / InputStream cleaning #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for new features, create a separate output stage that can be attached either to yuv2rgb or convolution filter shader. This stage will include things like color management, RGB range conversion and dithering.
Implement a GLSLOutput class that can be passed to shaders to implement an output stage with RGB range conversion and dithering. Add support for GLSLOutput in YUV2RGBShader and ConvolutionFilterShader. Single pass rendering to full range is not optimal as the range conversion could be done in colorspace conversion matrix. Keeping video levels avoids banding in multipass rendering though.
FernetMenta
force-pushed
the
master
branch
5 times, most recently
from
1bc7dec
to
585587f
Compare
FernetMenta
force-pushed
the
master
branch
3 times, most recently
from
5f781f5
to
4870a01
Compare
FernetMenta
force-pushed
the
master
branch
3 times, most recently
from
af42298
to
725f4b8
Compare
FernetMenta
force-pushed
the
master
branch
3 times, most recently
from
de69813
to
2fc223a
Compare
FernetMenta
force-pushed
the
master
branch
2 times, most recently
from
1d060b0
to
b7e9c26
Compare
FernetMenta
force-pushed
the
master
branch
6 times, most recently
from
16dc03f
to
7d62856
Compare
FernetMenta
force-pushed
the
master
branch
3 times, most recently
from
d0743dc
to
a1ddd14
Compare
FernetMenta
force-pushed
the
master
branch
2 times, most recently
from
608b20f
to
4554c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this here for comment.
It currently will break RTMP and PVR CloseAndOpen, but it compiles and basic usage works for me.