forked from adlnet/xapi-profiles
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra Profile Properties #12
Open
FeLungs
wants to merge
2
commits into
master
Choose a base branch
from
extra_props
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
* 2.1. [MUST / SHOULD / MAY](./xapi-profiles-about.md#def-must-should-may) | ||
* 2.2. [Guidelines for Interpreting Descriptive Text and Tables](./xapi-profiles-about.md#interpret-text-table) | ||
* 3.0. [Definitions](./xapi-profiles-about.md#definitions) | ||
* Part Two: [xAPI Profiles Document Structure Specification](./xapi-profiles-structure.md#part-two) | ||
* Part Two: [xAPI Profiles Document Structure Specification](./xapi-profiles-structure.md#part-two) | ||
* 1.0. [Reference Specifications](./xapi-profiles-structure.md#ref-spec) | ||
* 2.0. [Technical Foundations](./xapi-profiles-structure.md#tech-foundations) | ||
* 3.0. [Structure](./xapi-profiles-structure.md#structure) | ||
|
@@ -24,7 +24,7 @@ | |
* 8.1. [Statement Template Rules](./xapi-profiles-structure.md#statement-template-rules) | ||
* 9.0. [Patterns](./xapi-profiles-structure.md#patterns) | ||
* 10.0. [The Context](./xapi-profiles-structure.md#context) | ||
* Part Three: [xAPI Profiles Communication and Processing Specification](./xapi-profiles-communication.md#part-three) | ||
* Part Three: [xAPI Profiles Communication and Processing Specification](./xapi-profiles-communication.md#part-three) | ||
* 1.0. [Profile Server](./xapi-profiles-communication.md#prof-server) | ||
* 1.1. [Profile Versions](./xapi-profiles-communication.md#prof-versions) | ||
* 1.2. [Best Practices](./xapi-profiles-communication.md#best-practices) | ||
|
@@ -71,8 +71,8 @@ To assist in accomplishing these two primary goals, Profiles also contain metada | |
* All properties in tables are required in all cases unless marked optional. | ||
* Properties marked optional may be required in some situations. If no additional information is provided on the usage of an optional property, including it or not is entirely up to the Profile author. | ||
* All properties that are not JSON-LD keywords (or aliases thereof) MUST expand to absolute IRIs during processing as defined in the JSON-LD specification. | ||
* All properties that are not JSON-LD keywords (or aliases thereof) and not described by this specification MUST be expressed using compact IRIs or absolute IRIs. | ||
* JSON-LD keywords (or aliases thereof) that are not specified as properties in this document MAY be included anywhere they are legal in JSON-LD. | ||
* A Profile MUST only include properties defined in this document and JSON-LD keywords (or aliases thereof). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as previous comment |
||
* Values in a Profile MUST NOT be: empty objects, null, empty strings, or empty arrays. | ||
* All requirements on the structure of Profiles MUST be followed by Profile Authors. | ||
* All requirements on Statements following Profiles MUST be followed by Learning Record Providers when authoring Statements and by Profile Validators when validating Statements. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use SHALL and SHALL NOT to align with IEEE style ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Profile Server Version handling, what are the requirements for releasing a new version. Does the author of the profile manage / maintain the profile versions or is that solely a responsibility of the profile server.
-> Initial thoughts, profile server shouldn't be the only place that handles versioning, authors should be expected to include the version info in their profiles so that the version information is not lost on upload to a profile server.
-> Profile server may offer publish mechanics which applies publishes changes to a profile as a new version
There should / will be a Profile Server subgroup that gets into the details of what the Profile Server requirements are. The requirements added here were in relation to the additional properties requirement change.