Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 1.0.0 리젝 요청 사항 수정 #191

Merged
merged 2 commits into from
Jan 15, 2024
Merged

[Fix] 1.0.0 리젝 요청 사항 수정 #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd0b55
[Fix] 회원탈퇴 동작 안되는 버그 수정
eung7 Jan 15, 2024
364f61d
[Fix] 앱정보 작동하지 않는 셀 임시 삭제
eung7 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Favor/Favor.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,7 +2162,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.1.0;
MARKETING_VERSION = 1.0.0;
OTHER_LIBTOOLFLAGS = "-WLinkingC true -XCBuildForPre true -XCExpApple true";
PRODUCT_BUNDLE_IDENTIFIER = com.favor.Favor.iOS;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -2206,7 +2206,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.1.0;
MARKETING_VERSION = 1.0.0;
OTHER_LIBTOOLFLAGS = "-WLinkingC true -XCBuildForPre true -XCExpApple true";
PRODUCT_BUNDLE_IDENTIFIER = com.favor.Favor.iOS;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
2 changes: 1 addition & 1 deletion Favor/Favor/Sources/Scenes/Profile/Common/Views/ProfileView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public final class ProfileView: UIView {
self.setupConstraints()
self.bind()
}

required init?(coder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}
Expand Down
2 changes: 1 addition & 1 deletion Favor/Favor/Sources/Scenes/Settings/Reactors/SettingsAuthInfoViewReactor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public final class SettingsAuthInfoViewReactor: Reactor, Stepper {
case .signoutDidRequested:
self.handleSignOut()
return .empty()

case .deleteAccountDidRequested:
return self.handleDeleteAccount()
.asObservable()
Expand Down
4 changes: 2 additions & 2 deletions Favor/Favor/Sources/Scenes/Settings/SettingsRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ private extension SettingsRenderer {
title: "리마인더 알림"
),
Item(type: .tappable, section: .appInfo, title: "버전", staticInfo: version),
Item(type: .navigatable, section: .appInfo, title: "팀", step: .devTeamInfoIsRequired),
Item(type: .navigatable, section: .appInfo, title: "개발자 응원하기", step: .devTeamSupportIsRequired),
// Item(type: .navigatable, section: .appInfo, title: "팀", step: .devTeamInfoIsRequired),
// Item(type: .navigatable, section: .appInfo, title: "개발자 응원하기", step: .devTeamSupportIsRequired),
Item(type: .navigatable, section: .appInfo, title: "서비스 이용약관", step: .serviceUsageTermIsRequired(terms[0].url)),
Item(type: .navigatable, section: .appInfo, title: "개인정보 처리방침", step: .privateInfoManagementTermIsRequired(terms[1].url))
]
Expand Down
6 changes: 4 additions & 2 deletions Favor/Favor/Sources/Scenes/Settings/ViewControllers/SettingsAuthInfoVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ private extension SettingsAuthInfoViewController {
self.present(signOutPopup, animated: false)
}
}

func presentDeleteAccountPopup() {
let description = NewAlertPopup.Description(
description: Typo.deleteAccountDescription,
Expand All @@ -209,7 +209,9 @@ private extension SettingsAuthInfoViewController {
identifier: PopupIdentifier.deleteAccount
)
deleteAccountPopup.modalPresentationStyle = .overFullScreen
deleteAccountPopup.delegate = self
deleteAccountPopup.accpetButtonCompletion = {
self.reactor?.action.onNext(.deleteAccountDidRequested)
}

DispatchQueue.main.async {
self.present(deleteAccountPopup, animated: false)
Expand Down
Loading