Skip to content

Commit

Permalink
[Fix] 1.0.0 리젝 요청 사항 수정 (#191)
Browse files Browse the repository at this point in the history
  • Loading branch information
eung7 authored Jan 15, 2024
2 parents 46d8027 + 364f61d commit 59d4d14
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Favor/Favor.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -2162,7 +2162,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.1.0;
MARKETING_VERSION = 1.0.0;
OTHER_LIBTOOLFLAGS = "-WLinkingC true -XCBuildForPre true -XCExpApple true";
PRODUCT_BUNDLE_IDENTIFIER = com.favor.Favor.iOS;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -2206,7 +2206,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 0.1.0;
MARKETING_VERSION = 1.0.0;
OTHER_LIBTOOLFLAGS = "-WLinkingC true -XCBuildForPre true -XCExpApple true";
PRODUCT_BUNDLE_IDENTIFIER = com.favor.Favor.iOS;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public final class ProfileView: UIView {
self.setupConstraints()
self.bind()
}

required init?(coder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public final class SettingsAuthInfoViewReactor: Reactor, Stepper {
case .signoutDidRequested:
self.handleSignOut()
return .empty()

case .deleteAccountDidRequested:
return self.handleDeleteAccount()
.asObservable()
Expand Down
4 changes: 2 additions & 2 deletions Favor/Favor/Sources/Scenes/Settings/SettingsRenderer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ private extension SettingsRenderer {
title: "리마인더 알림"
),
Item(type: .tappable, section: .appInfo, title: "버전", staticInfo: version),
Item(type: .navigatable, section: .appInfo, title: "", step: .devTeamInfoIsRequired),
Item(type: .navigatable, section: .appInfo, title: "개발자 응원하기", step: .devTeamSupportIsRequired),
// Item(type: .navigatable, section: .appInfo, title: "팀", step: .devTeamInfoIsRequired),
// Item(type: .navigatable, section: .appInfo, title: "개발자 응원하기", step: .devTeamSupportIsRequired),
Item(type: .navigatable, section: .appInfo, title: "서비스 이용약관", step: .serviceUsageTermIsRequired(terms[0].url)),
Item(type: .navigatable, section: .appInfo, title: "개인정보 처리방침", step: .privateInfoManagementTermIsRequired(terms[1].url))
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ private extension SettingsAuthInfoViewController {
self.present(signOutPopup, animated: false)
}
}

func presentDeleteAccountPopup() {
let description = NewAlertPopup.Description(
description: Typo.deleteAccountDescription,
Expand All @@ -209,7 +209,9 @@ private extension SettingsAuthInfoViewController {
identifier: PopupIdentifier.deleteAccount
)
deleteAccountPopup.modalPresentationStyle = .overFullScreen
deleteAccountPopup.delegate = self
deleteAccountPopup.accpetButtonCompletion = {
self.reactor?.action.onNext(.deleteAccountDidRequested)
}

DispatchQueue.main.async {
self.present(deleteAccountPopup, animated: false)
Expand Down

0 comments on commit 59d4d14

Please sign in to comment.