Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSTEP-10] Migrate remaining datetime module tests to JUnit 5 #348

Merged
merged 16 commits into from
Jan 27, 2025
Merged

[JSTEP-10] Migrate remaining datetime module tests to JUnit 5 #348

merged 16 commits into from
Jan 27, 2025

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Jan 27, 2025 •
edited
Loading

part of #339
blocked by #347

@JooHyukKim
Add Junit5 to root pom.xml
4696077
@JooHyukKim
Migrate parameter names module tests to JUnit 5
fdae6ef
@JooHyukKim
Isolate JUnit 4 to datetime module
09a411e
@JooHyukKim
Migrate datatypes tests to JUnit 5
507e461
@JooHyukKim
Migrate parameter-names module tests
7636d44
@JooHyukKim
Migrate more JUnit test
e1125d5
@JooHyukKim
Migrate JUnit 4
d213198
@JooHyukKim
Migrate datetime module to JUnit 5
e8f7cd3 
Migrate datetime module to JUnit 5

Migrate some more

Complete test changes

Clean up more

Fix almost all

Fix more tests
@JooHyukKim
Merge branch '2.19' into 339-migrate-datetime
2129cc0
@JooHyukKim
Reduce changes
f890609
@JooHyukKim
Undo /key tests to minimize changes
541eb3b 
This reverts commit e8f7cd3.
@JooHyukKim
Remove unnecssary assertNotNull message
62966cb
@JooHyukKim
Revert "Reduce changes"
4d7f2d2 
This reverts commit f890609.
@JooHyukKim
Revert "Undo /key tests to minimize changes"
60fecb7 
This reverts commit 541eb3b.
@JooHyukKim
Remove junit 4
407bbe6
@JooHyukKim JooHyukKim changed the title [JSTEP-10] Migrate remaining datetime tests to JUnit 5 [JSTEP-10] Migrate remaining datetime module tests to JUnit 5 Jan 27, 2025
@JooHyukKim JooHyukKim marked this pull request as draft January 27, 2025 12:14
@cowtowncoder cowtowncoder marked this pull request as ready for review January 27, 2025 23:37
@cowtowncoder
Copy link
Member

Proceeding with this because I started the process. Will tackle that one failing unit test separately.

@cowtowncoder cowtowncoder merged commit 0b949e8 into FasterXML:2.19 Jan 27, 2025
0 of 4 checks passed
@cowtowncoder
Copy link
Member

@JooHyukKim Figured out most fails: there were cases where assumeTrue / assumeFalse were converted to assertions -- this is not correct as Assumptions behave different from Assertions.

There's also one other issue, wrt #207, should be able to resolve that too but first things first.

@JooHyukKim JooHyukKim deleted the 339-migrate-datetime-part2 branch January 28, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JooHyukKim @cowtowncoder