Support pattern for duration serializer #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obarcelonap
changed the title
obarcelonap
changed the title
datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/util/DurationUnitConverter.java
Outdated
Show resolved
Hide resolved
|
LGTM! @kupci WDYT? |
|
Yes, just looking at this in fact, and (much as I tried), could not find any issues, so yes, LGTM. Maybe @beamerblvd ? |
kupci
approved these changes
Oct 29, 2020
datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/DurationSerializer.java
Show resolved
Hide resolved
obarcelonap
force-pushed
the
support-pattern-for-duration-serializer
branch
from
77cb103 to
ed4c4ad
Compare
|
Ok, will merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not support duration serialization with fractions (see comments in #189). I would propose to merge first this so we can iterate and add fractions feature in the future.