-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoSuchMethodException in runtime for Kotlin 1.4 #557
Conversation
WDYT @dinomite @viartemev ? |
@cowtowncoder I made a snapshot build with this change and now basic things work fine with Kotlin 1.4 in my project. Can we merge it during the absence of maintainers? |
@Spikhalskiy np, I cherry-picked the fix into 2.13 branch. One thing I forgot to ask for is CLA, would it be possible to get that done? Unless you have done it before https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual way is to print it, fill & sign, scan/photo, email pdf/png/jpeg to |
Aside from CLA, I think it'd be great to figure out a way to use Github Actions to verify build against multiple different Kotlin core versions. I think it might as simple as just overriding Maven property |
@cowtowncoder About verifying the build... this will actually not build under kotlin 1.4, because the methods that were added in kotlin 1.5 are used. But it works fine. |
Ok good point wrt building. Github action can definitely be split in a way to build with 1.5, then just run test(s) with other "minor" versions. That actually makes more sense, too, since our release will have to use specific official dependency and it is output of that which has to pass test. |
Add an explicit language check before code checking for value classes
Closes #556