Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Object schema properties retain order (wrt @JsonPropertyOrder etc) (see #27) #76

Merged
merged 5 commits into from
Sep 11, 2015
Merged

Make Object schema properties retain order (wrt @JsonPropertyOrder etc) (see #27) #76

merged 5 commits into from
Sep 11, 2015

Conversation

idelvall
Copy link
Contributor

@idelvall idelvall commented Sep 1, 2015

Make Object schema properties retain order (wrt @JsonPropertyOrder etc) (see #27)

@cowtowncoder cowtowncoder mentioned this pull request Sep 9, 2015
Closed
@cowtowncoder cowtowncoder changed the title object schema property order Make Object schema properties retain order (wrt @JsonPropertyOrder etc) (see #27) Sep 9, 2015
cowtowncoder
cowtowncoder reviewed Sep 9, 2015
View reviewed changes
src/test/java/com/fasterxml/jackson/module/jsonSchema/TestReadJsonSchema.java
@@ -25,7 +25,6 @@
@JsonPropertyOrder(alphabetic=true)
static class SchemableBasic
{
public SchemaEnum testEnum;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal intentional?

@cowtowncoder
Copy link
Member

Thank you for the contribution -- it looks good, and I'd be happy to merge it.

Before merging, there is just one formality; we need a Contributor License Agreement. You can find document at https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf
and the simplest way is to print it, fill and sign, scan and email to info at fasterxml dot com.
(apologies if I have already asked for and received one -- I tried to verify this is not the case)

If you could do that, I will merge the patch and it will be part of 2.6.2 release (no hurry -- it will take a week to go through all recent bug reports and try to apply a few more fixes).

@idelvall
Copy link
Contributor Author

Hello Tatu. I have just sent the signed CLA

cowtowncoder added a commit that referenced this pull request Sep 11, 2015
@cowtowncoder
Merge pull request #76 from idelvall/master
2106546 
Make Object schema properties retain order (wrt @JsonPropertyOrder etc) (see #27)
@cowtowncoder cowtowncoder merged commit 2106546 into FasterXML:master Sep 11, 2015
@cowtowncoder cowtowncoder added this to the 2.6.2 milestone Sep 11, 2015
@cowtowncoder
Copy link
Member

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@idelvall @cowtowncoder