Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3275 in 2.12 (proposing micro-release 2.12.7.2) #4509

Merged
merged 2 commits into from
May 2, 2024

Conversation

millems
Copy link

@millems millems commented May 1, 2024

The AWS SDK for Java 1.x currently supports Java 7, which is probably a bad idea, but we have customers still using this JDK version.

Jackson, quite sanely, dropped support for Java 7 in 2.13. Until we can become equally sane, we'd really appreciate a micro-release to 2.12.7.2 to fix #3275 in the deprecated 2.12 line. Without this fix, our customers will need to manually update their Jackson version to get JDK 17+ support.

If you're generous enough to accept this pull request and release 2.12.7.2, I will sing your praises.

(Cherry-pick of 2f60d39)

@JooHyukKim
Copy link
Member

JooHyukKim commented May 1, 2024

Hmm... Is it impossible to do a patch on AWS SDK side?
This behavioral change is branching out from later releases, which is dangerous on maintenance perspective.

@millems
Copy link
Author

millems commented May 1, 2024

I'd be wide open to suggestions on how to avoid this from our end. We're not able to remove setCause from exceptions, which is what's causing the hiccup, but if we can somehow instruct the naming strategy logic to skip that field ourselves that would be an option.

Thankfully this behavior is already present in later releases, and this is just a backport, but really anything touching earlier releases is a pain, so I totally understand looking for alternatives.

@JooHyukKim
Copy link
Member

but if we can somehow instruct the naming strategy logic to skip that field ourselves that would be an option.

when it comes to customization, ObjectMapper is quite flexible 😆.
Maybe below ....

    mapper.setPropertyNamingStrategy(new PropertyNamingStrategy() {
        // implement your own naming strategy...
    }

.... approach would suit your case? Or there is bunch of other configuration methods.

Or maybe @cowtowncoder has better idea?

@cowtowncoder
Copy link
Member

@JooHyukKim As a background, I did discuss this with Amazon OSS folks earlier and indicated this would be acceptable. I can take care of the micro-patch.

@cowtowncoder
Copy link
Member

@millems quick question: I think this would be under AWS CCLA? Do you think anything is needed wrt addendums? I think you would be covered automatically, but wanted to double-check before merging just in case.

@millems
Copy link
Author

millems commented May 2, 2024

Yes! Thank you. It's all kosher.

@hyandell
Copy link

hyandell commented May 2, 2024

+1, this would be under AWS CCLA.

release-notes/CREDITS-2.x Outdated Show resolved Hide resolved
@pjfanning
Copy link
Member

pjfanning commented May 2, 2024

I am not a lawyer but the code in 2f60d39 is already licensed to this project. If someone else creates a copy of that code and submits it as a PR to another project or another branch (of this project) - they still are not the authors of the code. The original author of 2f60d39 is still the copyright holder. So at least in my head, there is no need for a CLA for this PR.

@cowtowncoder
Copy link
Member

Good point @pjfanning, I think you are right.

Fwtw I asked since in this case I knew the background for PR but it's all good either way.

@cowtowncoder cowtowncoder merged commit 14be345 into FasterXML:2.12 May 2, 2024
@cowtowncoder
Copy link
Member

Ok, released:

  • jackson-databind version 2.12.7.2
  • jackson-bom version 2.12.7.20240502 (with consistent version set including above)

and updated:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.12

Jars should get to Maven Central within 10-15 minutes.

@millems
Copy link
Author

millems commented May 2, 2024

You're awesome.

@hyandell
Copy link

hyandell commented May 3, 2024

100% agreed, thank you Jackson devs for your attention and work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants