Update NativeImageUtil method name and expose new getter
#4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Aug 1, 2023
|
@yawkat Could you please take a look when you have time? |
yawkat
reviewed
Aug 1, 2023
| * @since 2.16 | ||
| */ | ||
| public static boolean isInNativeImage() { | ||
| return System.getProperty("org.graalvm.nativeimage.imagecode") != null; |
There was a problem hiding this comment.
this check can be inlined into RUNNING_IN_SVM, because it doesnt care whether the value is buildtime or runtime.
There was a problem hiding this comment.
And still keep this method, right? Using in FasterXML/jackson-modules-base#217
There was a problem hiding this comment.
Ok so this should just return RUNNING_IN_SVM, right?
JooHyukKim
changed the title
NativeImageUtil method name and expose new getter isInSVM()NativeImageUtil method name and expose new getter
yawkat
approved these changes
Aug 2, 2023
|
these names are much better, thanks :) |
stevenschlansker
approved these changes
Aug 2, 2023
cowtowncoder
approved these changes
Aug 3, 2023
cowtowncoder
added a commit
that referenced
this pull request
Aug 3, 2023
JooHyukKim
deleted the
Update-NativeImageUtil-and-expose-getter-for-SVM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As discussed in FasterXML/jackson-modules-base#217 (comment))
Motivation
Checks around native image needs update
Modifications
isRunningInNativeImage()toisInNativeImageAndIsAtRuntime()privatefor method above (1)isInNativeImage()for only checking if we are in Native Image --will be used in Follow up wrt #191 by usingNativeImageUtil.isRunningInNativeImage()indatabindjackson-modules-base#217