-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the bug? that READ_ENUMS_USING_TO_STRING doesn't support null… #2307
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
package com.fasterxml.jackson.databind.deser.jdk; | ||
|
||
import static com.fasterxml.jackson.databind.DeserializationFeature.READ_ENUMS_USING_TO_STRING; | ||
|
||
import com.fasterxml.jackson.databind.node.ObjectNode; | ||
import java.io.IOException; | ||
import java.util.*; | ||
import java.util.concurrent.TimeUnit; | ||
|
@@ -527,4 +530,33 @@ public void testExceptionFromCustomEnumKeyDeserializer() throws Exception { | |
assertTrue(e.getMessage().contains("Undefined AnEnum")); | ||
} | ||
} | ||
|
||
// see here for real world example: | ||
// https://github.com/facebook/facebook-java-business-sdk/blob/v3.2.11/src/main/java/com/facebook/ads/sdk/CustomAudience.java#L4139 | ||
static enum EnumWithToStringNullValue { | ||
NON_NULL("NON_NULL"), | ||
NULL(null); | ||
|
||
private String value; | ||
|
||
private EnumWithToStringNullValue(String value) { | ||
this.value = value; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return value; | ||
} | ||
} | ||
|
||
static class PojoWithEnum { | ||
public EnumWithToStringNullValue enumWithToStringNullValue; | ||
} | ||
|
||
public void testEnumWithToStringNullValue() { | ||
ObjectMapper mapper = new ObjectMapper().enable(READ_ENUMS_USING_TO_STRING); | ||
ObjectNode on = mapper.createObjectNode(); | ||
on.put("enumWithToStringNullValue", "NON_NULL"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. w/out the supplied "fix", this throws an exception even through I'm not mapping the NULL enum. |
||
mapper.convertValue(on, PojoWithEnum.class); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe it should continue if e is null and not add anything to the map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like "skip nulls" approach: will use that.