-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to implement #1380: remove use of Moditect plug-in for 3.0 #1381
Trying to implement #1380: remove use of Moditect plug-in for 3.0 #1381
Conversation
@GedMarc Ok, I managed to put this together so that it finally builds & tests run. But for some reason, I was hoping you could sanity check whether changes make sense (plus if you have an idea of where |
FUDGE. It is all thanks to %)@$(#)^$#^# Will see if there's a way to RE-ADD it tho. |
Ok and the blocker is this issue: https://issues.apache.org/jira/browse/MSHADE-261 Because Maven shade plug-in will drop
|
Ok this has been tough one, but at this point build fully works, ending up with
which is pretty convoluted way to make it. But I could not figure a simpler way... :-( Also had to simplify FastDoubleParser shading; use of names did not work for some reason. Next to tackle FasterXML/jackson-databind#4891 (will try to get that working before merging this in). |
@GedMarc @pjfanning @JooHyukKim Just FYI: getting things properly JPMS modularized is pretty challenging. But after |
For #1380