Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant no-arg constructor #251

Closed

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Apr 26, 2024

Kindly review and advise if this makes sense to merge into 2.15 or whether it should go straight to 2.18 and 3.x

@cowtowncoder
Copy link
Member

Yes let's rebase to 2.18 since it really doesn't greatly matter; no more 2.15 versions likely released and for annotations package we try to keep patch versions identical to original .0 (hence not to 2.17).

@cowtowncoder
Copy link
Member

@Philzen Thank you for PRs! One process thing that is needed -- unless already done once -- is to get CLA, from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.
Only needs to be done before merging the first contribution, good for all current and future contributions.

Thank you -- and once CLA is in, PRs rebased to 2.18, will be happy to merge.

@Philzen
Copy link
Contributor Author

Philzen commented Apr 28, 2024

Closed in favor of #253

@Philzen Philzen closed this Apr 28, 2024
@Philzen Philzen deleted the 2-15-remove-redundant-enum-no-arg-ctor branch May 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants