Atleth bonding accounting #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (_deposits < _claims + _withdrawals) { | ||
| // CASE: in deficit, subtract from bonded balance | ||
| uint256 amountOwed = _claims + _withdrawals - _deposits; | ||
| if (_assign(winningSolver, amountOwed)) revert InsufficientTotalBalance((_claims + _withdrawals) - deposits); |
There was a problem hiding this comment.
Can we just use amountOwed here as its calculated the same way, just above?
Suggested change
| if (_assign(winningSolver, amountOwed)) revert InsufficientTotalBalance((_claims + _withdrawals) - deposits); | |
| if (_assign(winningSolver, amountOwed)) revert InsufficientTotalBalance(amountOwed); |
There was a problem hiding this comment.
so amountOwed uses _deposits, a memory variable, whereas the revert uses deposits, which is a storage variable. The reason the revert uses the storage variable is because _assign() increments it up to where we need it to be to calculate the shortfall rather than the total amount owed.
There was a problem hiding this comment.
it may be redundant though... that storage write in _assign doesn't need to happen at the end. There's probably a better way to do it.
Co-authored-by: Ben Sparks <[email protected]>
Co-authored-by: Ben Sparks <[email protected]>
Co-authored-by: Ben Sparks <[email protected]>
…nc in AtlETH so automatically draw from any free unbonding atlETH.
…y - gas cost should only accrue to irresponsible actors, and be marginally cheaper for everyone else
…ne-Labs/atlas into atleth-bonding-accounting
…ne-Labs/atlas into atleth-bonding-accounting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
note the _assign() and _credit() methods in GasAccounting.