Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor comments in if-else blocks #50

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Refactor comments in if-else blocks #50

merged 1 commit into from
Nov 18, 2023

Conversation

jj1980a
Copy link
Contributor

@jj1980a jj1980a commented Nov 17, 2023

Moving comments in the block scope they are intended to be.

From:

// comment for if
if (condition1) {
    ...

    // comment for following else if
} else if (condition2) {
    ...

    // comment for following else
} else {
    ...
}

To:

if (condition1) {
    // comment for current if
    ...
} else if (condition2) {
    // comment for current else if
    ...
} else {
    // comment for current else
    ...
}

Base automatically changed from forge-fmt to ci-cd-fix November 17, 2023 11:20
Base automatically changed from ci-cd-fix to main November 17, 2023 11:38
Copy link
Contributor

@BenSparksCode BenSparksCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jj1980a jj1980a merged commit 994683b into main Nov 18, 2023
3 checks passed
@jj1980a jj1980a deleted the if-else-comments branch November 18, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants