Redstone OEV dAppControl update #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
202
to
205
| SafeTransferLib.safeTransferETH( | ||
| RedstoneOevDappControl(_control()).oevAllocationDestination(), | ||
| bidAmount - _oevShareBundler - _oevShareFastlane | ||
| ); |
There was a problem hiding this comment.
Maybe we should calculate the result of bidAmount - _oevShareBundler - _oevShareFastlane and only if not zero, do the transfer call. Looks like it could be zero from the restrictions on the setter functions.
| uint256 public oevShareBundler; | ||
| uint256 public oevShareFastlane; | ||
|
|
||
| address public oevAllocationDestination; | ||
|
|
||
| mapping(address bundler => bool isWhitelisted) public bundlerWhitelist; | ||
| uint32 public NUM_WHITELISTED_BUNDLERS = 0; |
There was a problem hiding this comment.
Could name using camel case as all caps kinda implies its a constant, but it is not.
|
|
||
| mapping(address bundler => bool isWhitelisted) public bundlerWhitelist; | ||
| uint32 public NUM_WHITELISTED_BUNDLERS = 0; | ||
|
|
||
| mapping(address oracle => bool isWhitelisted) public oracleWhitelist; | ||
| uint32 public NUM_WHITELISTED_ORACLES = 0; |
There was a problem hiding this comment.
Could name using camel case as all caps kinda implies its a constant, but it is not.
BenSparksCode
approved these changes
Sep 23, 2024
aanand1
approved these changes
Sep 23, 2024
aanand1
reviewed
Sep 23, 2024
| @@ -52,31 +65,49 @@ contract RedstoneOevDappControl is DAppControl { | |||
| trustedOpHash: false, | |||
| invertBidValue: false, | |||
| exPostBids: false, | |||
There was a problem hiding this comment.
Should we make this ex-post-bids? That way it is easier for the solver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.