Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OoT] Fix issue where light settings is using the wrong name #493

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Yanis002
Copy link
Contributor

not sure how this wasn't caught earlier lol

@Yanis002 Yanis002 added bug Something isn't working oot Has to do with the Ocarina of Time 64 side labels Jan 17, 2025
Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault I think, oh if only python had the concept of a const

@gheskett
Copy link
Contributor

Apparently Python 3.8+ supports the final keyword, which are more or less the same thing as constants. Apart from that, I think Python convention is to use fully uppercase variable names for anything that should behave as if it should be a constant.

@Yanis002
Copy link
Contributor Author

My fault I think, oh if only python had the concept of a const

I thought it was my fault actually, I should have seen this earlier tbh

@Yanis002 Yanis002 merged commit 003bd49 into Fast-64:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working oot Has to do with the Ocarina of Time 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants