Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F3D] Implement Animal Crossing F3DZEX Extensions #357

Open
wants to merge 91 commits into
base: main
Choose a base branch
from

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Jun 7, 2024

Used in the hle renderer in Animal Crossing.

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Jul 19, 2024

Branch is now up to date with main

@Lilaa3 Lilaa3 added the f3d Has to do with the "f3d" code common to all games label Aug 2, 2024
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference there is a list of f3dex2 ucodes and some games they're used in, in the readme at https://github.com/Mr-Wiseguy/f3dex2 (animal crossing = animal forest)

it may be worthwhile to name the ucodes per their version name, like 2.08J for AC, rather than by the game they're used in.
For example different versions of OoT use different ucodes: n64 releases use 2.06H, gamecube releases use 2.08H which notably adds point lighting. naming one "n64 oot" and the other "gc oot" (or "mm") sounds weird
And one may want to use a different ucode in a hack and it would be weird to eg use the "F3DZEX AC" ucode in OoT

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 7, 2024

for reference there is a list of f3dex2 ucodes and some games they're used in, in the readme at https://github.com/Mr-Wiseguy/f3dex2 (animal crossing = animal forest)

it may be worthwhile to name the ucodes per their version name, like 2.08J for AC, rather than by the game they're used in. For example different versions of OoT use different ucodes: n64 releases use 2.06H, gamecube releases use 2.08H which notably adds point lighting. naming one "n64 oot" and the other "gc oot" (or "mm") sounds weird And one may want to use a different ucode in a hack and it would be weird to eg use the "F3DZEX AC" ucode in OoT

Techinically the ucode "is" the same as mm's internaly but that.. does not describe the ucode because it's extended with a lot of commands to assist the hle renderer, I'm gonna confirm with cuyler that there is no internal name nonetheless

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 7, 2024

Cuyler confirmed to me that he hasn´t seen any special internal ucode name that could be used, that said if you'd like a better name I'm open to suggestions @Dragorn421 , maybe F3DZEX2 (AC) would at least be closer (that's what cuyler calls it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f3d Has to do with the "f3d" code common to all games
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants