Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Homebrew Game Mode #351

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

jesusyoshi54
Copy link
Collaborator

Game specific panels are hidden and homebrew_compatible type options are used while in that game mode.

…nd 'homebrew_compatible' type options are used while in that game mode
@jesusyoshi54
Copy link
Collaborator Author

Issue #342 should be solved with this PR

@Lilaa3
Copy link
Collaborator

Lilaa3 commented May 31, 2024

Can I convince you to add some quick and dirty update logic for this during upgrade_changed_props

for scene in bpy.data.scenes:
        if scene.get("decomp_compatible", False):
            scene.gameEditorMode = "Homebrew"
            del scene["decomp_compatible"]

Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, operators work correctly, upgrade code is implemented as requested

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Jun 11, 2024

I wonder if there is a good way to standardize upgrade logic

@jesusyoshi54
Copy link
Collaborator Author

Maybe for a cleanup PR. It definitely could be something thrown into utilities

@jesusyoshi54 jesusyoshi54 merged commit 1259f48 into Fast-64:main Jun 13, 2024
1 check passed
@jesusyoshi54 jesusyoshi54 deleted the homebrew_game_mode branch July 28, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants