Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F3D] Pipe Sync Optimization #337

Merged
merged 4 commits into from
May 12, 2024
Merged

Conversation

jesusyoshi54
Copy link
Collaborator

gsSP cmds will export before using a pipe sync, which will theoretically save a minor amount of time. Mat bleed will also optimize pipe syncs within a mesh by removing pipe sync cmds if there is no gsDP cmd.

Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks to be perfect aside from the thing I commented on, my export of mario worked perfectly ingame and the displaylist looked just as perfect. This is a great addition!

fast64_internal/f3d/f3d_bleed.py Outdated Show resolved Hide resolved
fast64_internal/f3d/f3d_writer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@Lilaa3 Lilaa3 merged commit b0b752f into Fast-64:main May 12, 2024
1 check passed
@jesusyoshi54 jesusyoshi54 deleted the pipe_sync_opt branch June 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants