Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix draggable menu items in pattern pieces & pref dialogs #1209

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

DSCaskey
Copy link
Contributor

This PR disables dragging the menu items in the Preferences and Pattern Piece dialogs which prevents them from dragging and dropping.

closes issue#1205

Copy link

what-the-diff bot commented Nov 11, 2024

PR Summary 📝

Let's cheer for these awesome improvements! 🎉😃

  • User Interaction Enhancement 🖱️💡
    We have added a brand new property known as flags to multiple items within dialogpreferences.ui and pattern_piece_dialog.ui. This makes these elements interactive, letting users select and check them. Great for ease of use!

  • Code Optimization 🧹🚀
    The inclusion statements' order has been tidied up. We moved theme.qrc to be included in files dialogpreferences.ui and pattern_piece_dialog.ui for optimal organization. This keeps everything clean and easy to manage.

  • Design Improvement 🎨💫
    There's been a subtle change in the rectangle dimensions inside pattern_piece_dialog.ui. The width has been streamlined from 362 to 264 and height from 558 to 486. All about making things look just perfect!

  • Additional Insights Button 🎯🔘
    We introduced notchSubType_ButtonGroup to the buttongroups section in pattern_piece_dialog.ui. This gives more options and insights at user's fingertips.

An exciting update, isn't it? All these modifications are designed to improve the user experience and efficiency! 🎉🚀😄

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thank you!

@DSCaskey DSCaskey merged commit 2032630 into develop Nov 18, 2024
10 checks passed
@DSCaskey DSCaskey deleted the fix-menu-items-in-prefs-and-pieces-dialogs branch November 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: The menus in the pattern piece dialog can be duplicated with a drag-and-drop
3 participants