Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(walker2d_v4): add forward/health reward and ctrl cost to step info #603

Closed

Conversation

rickstaa
Copy link

@rickstaa rickstaa commented Jul 12, 2023

This pull request adds the Forward and Health reward and control cost to the info dictionary that is returned by the step method of the walker2d_v4 environment. This was done to improve consistency with the other environments.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…p info

This commit adds the 'reward_forward', 'reward_ctrl' and 'reward_survive' to the
info dict that the `step` method returns. This was done to
improve consistency with the other environments.
@rickstaa rickstaa force-pushed the extend_walker2d_info branch from 9a90b41 to 3b39c22 Compare July 12, 2023 11:39
@pseudo-rnd-thoughts
Copy link
Member

Closing for the same reason as #602

@rickstaa rickstaa deleted the extend_walker2d_info branch July 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants