Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Randomize output of eth_feeHistory to mimic ETH API #511

Merged
merged 2 commits into from
Sep 14, 2023
Merged

API: Randomize output of eth_feeHistory to mimic ETH API #511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5fce8
api: randomize output of eth_feeHistory to mimic ETH API
uprendis Sep 13, 2023
f4703ee
api: add note for eth_feeHistory
uprendis Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions ethapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"errors"
"fmt"
"math/big"
"math/rand"
"time"

"github.com/Fantom-foundation/lachesis-base/hash"
Expand Down Expand Up @@ -89,6 +90,7 @@ type feeHistoryResult struct {
Reward [][]*hexutil.Big `json:"reward,omitempty"`
BaseFee []*hexutil.Big `json:"baseFeePerGas,omitempty"`
GasUsedRatio []float64 `json:"gasUsedRatio"`
Note string `json:"note"`
}

var errInvalidPercentile = errors.New("invalid reward percentile")
Expand Down Expand Up @@ -128,17 +130,35 @@ func (s *PublicEthereumAPI) FeeHistory(ctx context.Context, blockCount rpc.Decim

baseFee := s.b.MinGasPrice()

tips := make([]*hexutil.Big, 0, len(rewardPercentiles))
tips := make([]*big.Int, 0, len(rewardPercentiles))
for _, p := range rewardPercentiles {
tip := s.b.SuggestGasTipCap(ctx, uint64(gasprice.DecimalUnit*p/100.0))
tips = append(tips, (*hexutil.Big)(tip))
tips = append(tips, tip)
}
res.OldestBlock.ToInt().SetUint64(uint64(oldest))
for i := uint64(0); i < uint64(last-oldest+1); i++ {
res.Reward = append(res.Reward, tips)
// randomize the output to mimic the ETH API eth_feeHistory for compatibility reasons
rTips := make([]*hexutil.Big, 0, len(tips))
for _, t := range tips {
rTip := t
// don't randomize last iteration
if i < uint64(last-oldest) {
// increase by up to 2% randomly
rTip = new(big.Int).Mul(t, big.NewInt(int64(rand.Intn(gasprice.DecimalUnit/50)+gasprice.DecimalUnit)))
rTip.Div(rTip, big.NewInt(gasprice.DecimalUnit))
}
rTips = append(rTips, (*hexutil.Big)(rTip))
}
res.Reward = append(res.Reward, rTips)
res.BaseFee = append(res.BaseFee, (*hexutil.Big)(baseFee))
res.GasUsedRatio = append(res.GasUsedRatio, 0.99)
}
r := rand.New(rand.NewSource(int64(oldest) + int64(i)))
res.GasUsedRatio = append(res.GasUsedRatio, 0.9+r.Float64()*0.1)
}
res.Note = `In the FTM network, the eth_feeHistory method operates slightly differently due to the network's unique consensus mechanism. ` +
`Here, instead of returning a range of gas tip values from requested blocks, ` +
`it provides a singular estimated gas tip based on a defined confidence level (indicated by the percentile parameter). ` +
`This approach means that while you will receive replicated (and randomized) reward values across the requested blocks, ` +
`the average or median of these values remains consistent with the intended gas tip.`
return res, nil
}

Expand Down
Loading