Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructing Message from Transaction for internal transactions (Transaction tracing) #491

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jenikd
Copy link
Collaborator

@jenikd jenikd commented Jul 27, 2023

This PR fixes creation of Message from Transaction, for internal transactions in tranaction tracing. It was failing, because sender in this case is zero address and message was not able to be created and that was causing transaction not to be able to replay and generate transaction trace.

Solves #487

@jenikd jenikd requested a review from andrecronje as a code owner July 27, 2023 13:36
@jenikd jenikd requested a review from uprendis July 27, 2023 13:37
@uprendis uprendis merged commit 11c63ca into develop-tracing Jul 27, 2023
1 check passed
@jenikd jenikd deleted the HonzaDajc/fix_msg_internal_tx branch July 10, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants