Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floria: state contract fix nonce endian #973

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

simonlechner
Copy link
Contributor

The nonce in the state contract has been set with the wrong endian.

@simonlechner simonlechner added this to the Tosca EVM milestone Dec 18, 2024
@simonlechner simonlechner requested a review from LuisPH3 December 18, 2024 09:47
@simonlechner simonlechner self-assigned this Dec 18, 2024
@simonlechner simonlechner requested a review from facuMH December 18, 2024 10:30
Copy link
Contributor

@facuMH facuMH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fix, looks good. I'm wondering if this (or similar errors) can be caught in some way as to prevent similar endianess issues

@simonlechner simonlechner force-pushed the simon/floria-nonce-endian-fix branch from 4be62a1 to fdd8c86 Compare December 18, 2024 11:16
@simonlechner simonlechner merged commit 6985e61 into main Dec 18, 2024
6 checks passed
@simonlechner simonlechner deleted the simon/floria-nonce-endian-fix branch December 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants