evmzero: Add check for range in blockHash op #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuMH
force-pushed
the
facundo/evmzero-blockhash-range
branch
from
b2f4b5e to
193c401
Compare
facuMH
force-pushed
the
facundo/evmzero-blockhash-range
branch
from
193c401 to
b8c5272
Compare
HerbertJordan
requested changes
May 14, 2024
HerbertJordan
previously approved these changes
May 21, 2024
LuisPH3
previously approved these changes
May 21, 2024
facuMH
force-pushed
the
facundo/evmzero-blockhash-range
branch
from
d42b8e2 to
c0e6d70
Compare
HerbertJordan
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the BLOCKHASH operation by adding a check that the number of the block to be hashed is within 256 of the current block.
This PR adds a test for the case when the block to be hashed is outside of this range, in this case the returned hash is 0 and a regression test case for the CT.